Limit CI runtime on Windows runners #520
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, our CI is "failing" because the codecov-action gets stuck for Windows runners despite the last line showing
info - 2024-03-07 05:18:14,167 -- Process Upload complete
. It seems this success is not correctly registered so that the workflow doesn't move to the next job. See alsoAt the moment, this PR simply applies a time limit to this CI step (1 minute should be plenty for a step that usually takes ~5s), but the step will then still fail. So we might want to explore other options such as downgrading to codecov-action@v3.
Another option would probably be to run codecov as a command line tool manually.
How to review
Please check the added comment is enough to understand how/when to remove this temporary addition. The CI is not expected to pass on Windows runners.
PR checklist
[ ] Add or expand tests; coverage checks both ✅No intention to keep this change[ ] Add, expand, or update documentation.No intention to keep this change[ ] Update release notes.No intention to keep this change