Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our whole CI is failing (same for several downstream projects) because one of the pytest hooks here is using a deprecated argument:
startdir
has been replaced bystart_path
. This was kindly pointed out in pytest-dev/pytest#12061, though I have to admit even with the linked deprecation changelog, this might not have been entirely clear to me. After all, the changelog says the hook is now receiving 'additional arguments', not 'changed arguments'. Either way, this PR includes the fix.Should we update the release notes since other projects might have seen failures due to the hook arguments being out of date? If so, we haven't received an issue yet.
How to review
PR checklist
[ ] Add or expand tests; coverage checks both ✅Just an internal change[ ] Add, expand, or update documentation.Just an internal change[ ] Update release notes.Just an internal change