Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pre-commit to invoke ruff, mypy #492

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Use pre-commit to invoke ruff, mypy #492

merged 4 commits into from
Sep 19, 2023

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Sep 6, 2023

See iiasa/message_ix#742. This also includes the job step from iiasa/message-ix-models#124 / iiasa/message-ix-models#127.

Also:

How to review

Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update release notes.

@khaeru khaeru added enh New features & functionality ci Continuous integration labels Sep 6, 2023
@khaeru khaeru self-assigned this Sep 6, 2023
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #492 (3333827) into main (3a5479c) will decrease coverage by 0.1%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##            main    #492     +/-   ##
=======================================
- Coverage   98.5%   98.5%   -0.1%     
=======================================
  Files         42      42             
  Lines       4557    4554      -3     
=======================================
- Hits        4493    4489      -4     
- Misses        64      65      +1     
Files Changed Coverage Δ
ixmp/__init__.py 100.0% <100.0%> (ø)

... and 1 file with indirect coverage changes

@khaeru khaeru force-pushed the enh/pre-commit branch 4 times, most recently from 0bbe649 to 2812e53 Compare September 6, 2023 19:09
@khaeru khaeru merged commit 565a546 into main Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration enh New features & functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant