Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.11 #481

Merged
merged 6 commits into from
May 11, 2023
Merged

Support Python 3.11 #481

merged 6 commits into from
May 11, 2023

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented May 3, 2023

Take advantage of genno >= 1.16, in which sparse is an optional/extra dependency.

Previously, via genno → sparse → numba → llvmlite, it was not possible to install/test ixmp with the latest Python; for example, Python 3.11 was released 2022-10-24, but numba 0.57 supporting Python 3.11 was not released until 2023-05-03, a lag of ~6 months.

Notes:

  • For Adjust for JPype1 v1.4.1 #463, we forced a downgrade of JPype1 to < 1.4.1. But JPype1 <= 1.4.0 is not available as binary wheels for Python 3.11. This PR does not force this downgrade for Python 3.11—and the tests seem to pass!
  • However, an experiment (see this run) confirms that the test failures still occur for Python 3.10, so we retain the workaround.

How to review

Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation. N/A
  • Update release notes.

@khaeru khaeru added enh New features & functionality ci Continuous integration labels May 3, 2023
@khaeru khaeru added this to the 3.7 milestone May 3, 2023
@khaeru khaeru self-assigned this May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #481 (bd7b78f) into main (3c922f4) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #481   +/-   ##
=====================================
  Coverage   98.5%   98.5%           
=====================================
  Files         42      42           
  Lines       4489    4489           
=====================================
  Hits        4425    4425           
  Misses        64      64           

Copy link
Member

@glatterf42 glatterf42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@khaeru khaeru merged commit 11024a8 into main May 11, 2023
@khaeru khaeru deleted the python-3.11 branch May 11, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration enh New features & functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants