Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing for v3.3; misc cleanup #416

Merged
merged 47 commits into from
May 26, 2021
Merged

Improve testing for v3.3; misc cleanup #416

merged 47 commits into from
May 26, 2021

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented May 25, 2021

This PR:

How to review

Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update release notes.

@khaeru khaeru self-assigned this May 25, 2021
@khaeru khaeru linked an issue May 25, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #416 (1bfdbdd) into main (0188de0) will increase coverage by 1.1%.
The diff coverage is 97.0%.

@@           Coverage Diff           @@
##            main    #416     +/-   ##
=======================================
+ Coverage   96.7%   97.9%   +1.1%     
=======================================
  Files         37      39      +2     
  Lines       4247    4238      -9     
=======================================
+ Hits        4111    4150     +39     
+ Misses       136      88     -48     
Impacted Files Coverage Δ
ixmp/__init__.py 100.0% <ø> (+9.0%) ⬆️
ixmp/backend/__init__.py 100.0% <ø> (ø)
ixmp/model/dantzig.py 100.0% <ø> (ø)
ixmp/tests/core/test_scenario.py 100.0% <ø> (ø)
ixmp/tests/test_config.py 100.0% <ø> (+4.4%) ⬆️
ixmp/utils.py 96.0% <ø> (+0.9%) ⬆️
ixmp/testing/resource.py 83.0% <83.0%> (ø)
ixmp/backend/jdbc.py 95.0% <90.9%> (-1.1%) ⬇️
ixmp/testing/__init__.py 95.8% <95.8%> (ø)
ixmp/testing/data.py 97.2% <97.2%> (ø)
... and 24 more

khaeru added 17 commits May 25, 2021 23:03
This leads to a roughly 50% reduction in the time to run the test suite.
This significantly improves performance in the test suite by reducing
the number of times new Platforms (and thus JDBCBackends) must be
created and populated.

Add a new fixture test_mp_f, with "_f" indicating function-scoped.
Adjust where these are used in other fixtures and (some) tests.
The file is shortened by about 30%.
In #270, this file was cleaned up and tests were collected in a class,
with parametrization. Shortly after, #264 was merged, which squashed
these improvements. This commit rescues the improvements and adapts
additions since then to the same pattern.
@khaeru khaeru added this to the 3.3 milestone May 26, 2021
@khaeru khaeru changed the title Improve testing for v3.3 Improve testing for v3.3; misc cleanup May 26, 2021
@khaeru
Copy link
Member Author

khaeru commented May 26, 2021

See #417.

@khaeru khaeru merged commit ef075f8 into main May 26, 2021
@khaeru khaeru deleted the issue/415 branch May 26, 2021 15:34
khaeru added a commit that referenced this pull request May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address CI failures with R/reticulate
1 participant