-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve testing for v3.3; misc cleanup #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #416 +/- ##
=======================================
+ Coverage 96.7% 97.9% +1.1%
=======================================
Files 37 39 +2
Lines 4247 4238 -9
=======================================
+ Hits 4111 4150 +39
+ Misses 136 88 -48
|
This leads to a roughly 50% reduction in the time to run the test suite.
This significantly improves performance in the test suite by reducing the number of times new Platforms (and thus JDBCBackends) must be created and populated. Add a new fixture test_mp_f, with "_f" indicating function-scoped. Adjust where these are used in other fixtures and (some) tests.
The file is shortened by about 30%.
khaeru
changed the title
Improve testing for v3.3
Improve testing for v3.3; misc cleanup
May 26, 2021
This was
linked to
issues
May 26, 2021
See #417. |
khaeru
added a commit
that referenced
this pull request
May 26, 2021
This was referenced May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
message model dir
does not work #415. The issue is not closed, as it awaits info.In particular, test_timeseries.py was improved in Test using in-memory databases and other clean-ups #270: duplicate tests were collected into a smaller number of simpler, parametrized tests that covered more behaviour, and these were collected in a class. These improvements were then squashed/reversed by Extend API to support dynamic time slices #264; see e66f3f8#diff-153145079fe9f6531ebb1e54aa22d353d2c89112fea960469a548ed0768a11ec. The PR corrects the error while preserving and improving additions over the past year. (Time: about 4 hours.)
config
andplatform
CLI commands to use click properly; addsconfig show
to show the config file location.ixmp show-versions
.How to review
Read the diff and note that the CI checks all pass.
PR checklist