Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GAMSmodel quiet= behaviour #405

Merged
merged 5 commits into from
Mar 8, 2021
Merged

Fix GAMSmodel quiet= behaviour #405

merged 5 commits into from
Mar 8, 2021

Conversation

khaeru
Copy link
Member

@khaeru khaeru commented Mar 8, 2021

How to review

No review: simple bugfix and CI changes only.

PR checklist

  • Continuous integration checks all ✅
  • Add or expand tests; coverage checks both ✅
  • Add, expand, or update documentation.
  • Update release notes. Correction to new behaviour that has not been released yet.

@khaeru khaeru self-assigned this Mar 8, 2021
@khaeru khaeru added the ci Continuous integration label Mar 8, 2021
@codecov
Copy link

codecov bot commented Mar 8, 2021

Codecov Report

Merging #405 (5f50de5) into master (40ad9c2) will decrease coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master    #405     +/-   ##
========================================
- Coverage    96.8%   96.8%   -0.1%     
========================================
  Files          37      37             
  Lines        4251    4247      -4     
========================================
- Hits         4117    4113      -4     
  Misses        134     134             
Impacted Files Coverage Δ
ixmp/model/gams.py 100.0% <100.0%> (ø)
ixmp/testing.py 79.2% <100.0%> (-0.6%) ⬇️
ixmp/tests/core/test_scenario.py 100.0% <100.0%> (ø)
ixmp/tests/reporting/test_reporter.py 99.0% <100.0%> (+<0.1%) ⬆️
ixmp/tests/test_integration.py 100.0% <100.0%> (ø)

@khaeru khaeru merged commit dae9035 into master Mar 8, 2021
@khaeru
Copy link
Member Author

khaeru commented Mar 8, 2021

@OFR-IIASA fyi, this is now merged.

@khaeru khaeru deleted the issue/404 branch March 8, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GAMSModel quiet option is inverted
1 participant