Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ixmp.jar and add postgres JDBC driver #197

Merged
merged 2 commits into from
Nov 1, 2019
Merged

Update ixmp.jar and add postgres JDBC driver #197

merged 2 commits into from
Nov 1, 2019

Conversation

zikolach
Copy link
Contributor

@zikolach zikolach commented Oct 30, 2019

  • ixmp.jar updated to most recent one
  • added PostgreSQL JDBC dependency

How to review

PR checklist

  • Tests added.
  • Documentation added.
  • Release notes updated.

@zikolach zikolach requested a review from khaeru October 31, 2019 10:57
@khaeru
Copy link
Member

khaeru commented Oct 31, 2019

@zikolach now that #182 is in, can you force-push this branch (with no changes) to trigger a CI restart?

@zikolach
Copy link
Contributor Author

@zikolach now that #182 is in, can you force-push this branch (with no changes) to trigger a CI restart?

Rebased on top of current master

@khaeru
Copy link
Member

khaeru commented Nov 1, 2019

All green, so seems good to go!

It would be nice to create an issue to add some tests on the Python side demonstrating PostgreSQL functionality.

@khaeru khaeru merged commit c2bed8b into master Nov 1, 2019
@khaeru khaeru added this to the 1.0 milestone Nov 1, 2019
@zikolach zikolach deleted the feature/pg branch November 15, 2019 12:20
@zikolach
Copy link
Contributor Author

All green, so seems good to go!

It would be nice to create an issue to add some tests on the Python side demonstrating PostgreSQL functionality.

@khaeru thanks for merging. We need to think also about running tests on oracle as currently we run them only using hsqldb. But maybe that's more related to testing java code - as db support isn't exposed anyhow to python.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants