Standartize member naming for Maps::FileInfo structure #9237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have two different structures: Maps::FileInfo and BaseMapFormat. Both of them have a lot of similarities. To avoid any confusion this rename has been done. Also, in the future we are going to modify Maps::FileInfo so that BaseMapFormat can own this structure.
Districh-ru
approved these changes
Oct 25, 2024
|
| uint8_t colorsAvailableForComp; | ||
| uint8_t availablePlayerColors; | ||
| uint8_t humanPlayerColors; | ||
| uint8_t computerPlayerColors; |
There was a problem hiding this comment.
Now these names look like these colors are specifically used by human (or computer) players while in fact it may not be really the case, because the same colors may be available both for a human player and for AI. In this regard, "colorsAvailableForXXX" sounds more right IMHO. But this is of course a matter of taste.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two different structures: Maps::FileInfo and BaseMapFormat. Both of them have a lot of similarities. To avoid any confusion this rename has been done. Also, in the future we are going to modify Maps::FileInfo so that BaseMapFormat can own this structure.