Replace <C-C><C-C> with <C-C> #366
Conversation
To elaborate, my thought was that an alternative way to handle this would be to have the CLI fix the issue right when reading the keylog file generated by Vim. Then all new submossions from the updated CLI wouldn't have the issue. But I thought that there may be users that don't update their CLI version frequently, and the current version of the PR would properly handle their entry upon submission (although if they were using an older CLI, the wrong keystrokes and score would still be shown when they're using the application, but not by the webapp after submission). Upon further thought, I'm less confident in the approach I implemented versus the alternative (having this handled immediately by the CLI when loading the keylog script). If you're interested in the general type of update in this PR (replacing |
| # Vim intentionally replaces "<C-C>" (\x03) with "<C-C><C-C>" (Vim #11541). | ||
| # Convert "<C-C><C-C>" back to "<C-C>" (VimGolf #224). | ||
| @input = input.force_encoding(Encoding::ASCII_8BIT).gsub("\x03\x03", "\x03") |
There was a problem hiding this comment.
I originally had the comment and update on separate lines, after the input.force_encoding line, but I moved them both here after a rubocop error from too many lines.
|
I'm going to close this for now, to explore the alternative approach I mentioned above. |
Vim intentionally replaces
<C-C>with<C-C><C-C>, which is reflected in the output when using-W(vim/vim#11541).In VimGolf, when a user enters
<C-C>, the input will count as two keystrokes towards the score, showing<C-C>twice in the displayed keystrokes.This PR updates the code to replace
<C-C><C-C>with<C-C>. This will allow the CLI to not double count<C-C>in the reported keystrokes and score. My motivation for handling this inkeylog.rb, rather than e.g.,cli.rb, is that the server code would be able to utilize this update as well. However, without updating the database, which appears to save scores, the scores would presumably still be incorrect for already-submitted solutions.This fixes #224.