Remove -Z when GOLFVIM=nvim #346
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For good anti-cheat/validation, it might make sense to validate the key presses on the server (no idea how that'd work, unlikely that would ever be implemented, just putting it out there) |
|
I would love to see this PR merged. It worked perfectly for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #304
This PR conditionally removes the
-Zflag when$GOLFVIMis set tonvim.This may make it slightly easier to cheat, but it doesn't really change that much considering that you can make a shellscript for
$GOLFVIMthat cuts out the first arg pretty easily. (exec nvim "${@:2}")I also changed the diff tool to use the provided vim by default, since most people that change
GOLFVIMwould expect vimgolf to use it for diff too.Making the experience for nvim slightly better.