Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: integer vectors are validated before transferring them to the C library #1582

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

szhorvat
Copy link
Member

Effects of this change:

  • Fixes cluster_label_prop() crashes R when using fixed labels #1434 and eliminates a potential way to crash igraph
  • Potential small performance penalty. Probably inconsequential, but not measured.
  • This can potentially trigger an UBSan warning, and that's okay. The warning will only be triggered when passing invalid values. If this happens, the test suite or examples should be changed.
  • Values that were in the past blindly rounded are now checked. May cause revdepcheck failures.

Copy link
Contributor

aviator-app bot commented Nov 12, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.


See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@szhorvat szhorvat requested a review from krlmlr November 12, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cluster_label_prop() crashes R when using fixed labels
1 participant