chore: use 'parent' instead of 'father' in bfs() and dfs()
#1523
+142
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Aviator status
This pull request is currently open (not queued). How to mergeTo merge this PR, comment
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
maelle
commented
Sep 23, 2024
szhorvat
approved these changes
Sep 24, 2024
|
This way you saw it's not even a breaking change 😸 |
2 tasks
krlmlr
reviewed
Nov 7, 2024
R/structural.properties.R
Outdated
| @@ -2150,6 +2155,13 @@ bfs <- function( | |||
| } | |||
| } | |||
|
|
|||
| if (lifecycle::is_present(father)) { | |||
| lifecycle::deprecate_warn("2.0.4", "bfs(father)", "bfs(parent)") | |||
There was a problem hiding this comment.
Surprisingly, this code works, but the following is a bit more correct because parent and father are argument names:
Suggested change
| lifecycle::deprecate_warn("2.0.4", "bfs(father)", "bfs(parent)") | |
| lifecycle::deprecate_warn("2.0.4", "bfs(father = )", "bfs(parent = )") |
| pred = TRUE, | ||
| succ = TRUE, | ||
| dist = TRUE | ||
| ) | ||
| }) | ||
| }) | ||
|
|
||
| test_that("bfs() deprecated argument", { | ||
| test_that("bfs() deprecated arguments", { | ||
| g <- graph_from_literal(a - +b - +c, z - +a, d) |
There was a problem hiding this comment.
#673 would take care of the style here. Can we somehow add this to the package (with .Rbuildignore) and configure/document the usage?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #880
It's not breaking anything as the functions still also return the "father" field.