Remove wkhtmltopdf-binary dependancy #18
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-alexandrov
added a commit
that referenced
this pull request
Oct 15, 2013
|
Done in 1.3.0! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recommend removing the wkhtmltopdf-binary dependency because it creates unnecessary bloat since it contains binaries irrelevant to the current platform.
I updated the docs to include info about adding the wkhtmltopdf-binary gem so users can still get up and running quickly. I kept the wkhtmltopdf-binary gem in the Gemfile for testing purposes.
This change is important in my case because I'm using my own binary of wkhtmltopdf 0.11.0_rc1 since it contains some performance improvements, and it also fixes a bug that allows anchor links to work within pdfs. Using wisepdf with wkhtmltopdf 0.11.0_rc1 I haven't run into any issues and the tests still pass when specifying that binary.