Feat/s cli remove disable auth #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billythedummy
changed the base branch from
master
to
feat/s-controller-cli-enable-pool
Merged
f8122dac91
changed the base branch from
feat/s-controller-cli-enable-pool
to
master
f8122dac91
reviewed
Feb 7, 2024
| use crate::{LstStateListBanksClient, PoolStateBanksClient}; | ||
| use crate::{DisablePoolAuthorityListBanksClient, LstStateListBanksClient, PoolStateBanksClient}; | ||
|
|
||
| // TODO: _for_prog() |
There was a problem hiding this comment.
yeh i think testing with _for_prog() and using program_ids different from the program::IDs is actually a valid test, cuz it will help us spot fuckups like using const for a pda where it shouldn't be
There was a problem hiding this comment.
can revisit this on a separate testing issue: #270
f8122dac91
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #240
Merge #262 first