-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[obsolete] grid refinement compatibility #438
Draft
pdziekan
wants to merge
38
commits into
igfuw:master
Choose a base branch
from
pdziekan:fractal
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th non-default options
Obsolete: currently with fractal refinement all microphysics are done on the refined grid, hence no changes in libcloudph++ are needed |
pdziekan
changed the title
grid refinement compatibility
[obsolete] grid refinement compatibility
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
two grids: normal and second, finer grid
condensation done on refined grid, everything else on normal grid
Abandoned for now.
Instead for grid refinement in UWLCM, entire microphysics are done on refined grid (hopefully without changes to libcloudph++).
input arrays that are on both grids (refined input needed only if n_ref>1, i.e. refinement is done):
th, rv, rhod, p
internal arrays on both grids:
dv, eta, count_ijk, count_mom, count_num
internal arrays on refined grid only:
T, RH
internal particle hskpng data required for both grids:
ijk, sorted_ijk
TODO:
currently working on the non-MPI version, things that will need to be fixed for MPI: