ArduPilot custom controller: Rename a_Kb, a_Kg -> a_b, a_g #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The choice of the variable names a_Kb and a_Kg were unfavorable. The variables are the acceleration in the body-fixed coordinate system b and earth-fixed coordinate system g. The index K indicates a motion from the body relative to the earth. However, the variables a_Kg and a_Kb are defined to represent the acceleration measured by the IMU and thus contain the gravitational acceleration. To avoid confusion in the future, the "K"s in the variable names have been removed. Moreover, the comments in the functions were supplemented, so that the definition of the variables becomes clear. Unfortunately, this change will cause errors in old projects.
fguecker
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The choice of the variable names a_Kb and a_Kg were unfavorable. The variables are the acceleration in the body-fixed coordinate system b and earth-fixed coordinate system g. The index K indicates a motion from the body relative to the earth. However, the variables a_Kg and a_Kb are defined to represent the acceleration measured by the IMU and thus contain the gravitational acceleration. To avoid confusion in the future, the "K"s in the variable names have been removed. Moreover, the comments in the functions were supplemented, so that the definition of the variables becomes clear.
Unfortunately, this change will cause errors in old projects.