Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address Roman's IESG review of the protocol document #494

Merged
merged 3 commits into from
Sep 25, 2023
Merged

Address Roman's IESG review of the protocol document #494

merged 3 commits into from
Sep 25, 2023

Conversation

chris-wood
Copy link
Collaborator

No description provided.

tfpauly
tfpauly approved these changes Sep 22, 2023
View reviewed changes
draft-ietf-privacypass-protocol.md
character limits):

~~~
$ echo MIIBUjA9BgkqhkiG9w0BAQowMKANMAsGCWCGSAFlAwQCAqEaMBgGCSqGSIb3DQEBCDAL \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is putting echo / openssl commands standard for such document?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's standard, but we already do this elsewhere in the document 🤷

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the openssl part, yeah. Cool.

@chris-wood chris-wood merged commit 63028a1 into main Sep 25, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tfpauly tfpauly tfpauly approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-wood @tfpauly