Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Include figure prefix in name before rendering text #966

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kesara
Copy link
Member

@kesara kesara commented Feb 2, 2023

Fixes ##961

@cabo
Copy link
Contributor

cabo commented Feb 2, 2023

Is the same fix needed for all the other uses of .tjoin()?
If not, why not?

@kesara kesara marked this pull request as draft February 2, 2023 20:07
@kesara
Copy link
Member Author

kesara commented Feb 2, 2023

Is the same fix needed for all the other uses of .tjoin()? If not, why not?

tjoin() is used to render reference, references -> name, section -> name, table -> name.
I'll experiment and see if this fix is adversely affecting any of those.

@cabo
Copy link
Contributor

cabo commented Feb 2, 2023

I'll experiment and see if this fix is adversely affecting any of those.

I just thought that they may have the same bug that Alice reported (line-breaking hyphens and putting them back together with a superfluous space), which would need to be fixed in a similar way.

@kesara kesara force-pushed the fix/text-wrap-issue-2 branch from 6365b94 to 1924291 Compare August 31, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants