Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid breaking text on hyphens #965

Closed
wants to merge 2 commits into from
Closed

fix: Avoid breaking text on hyphens #965

wants to merge 2 commits into from

Conversation

kesara
Copy link
Member

@kesara kesara commented Feb 2, 2023

Fixes #961

@cabo
Copy link
Contributor

cabo commented Feb 2, 2023

Wow, this change seems to have a wide-ranging effect.
Do we really want to stop breaking on hyphens everywhere?
Note that Unicode has a non-breaking hyphen character ‑, U+2011, for where this is actually desired.

@cabo
Copy link
Contributor

cabo commented Feb 2, 2023 •
edited
Loading

The bottom of tests/valid/draft-template.pages.text
has a nice example for why this change is generally undesirable (look for "onsiderations" [sic])..

cabo
cabo reviewed Feb 2, 2023
View reviewed changes
tests/valid/draft-template.pages.text
considerations-rfc2434bis-09.txt>.
Internet-Draft,
draft-narten-iana-considerations-rfc2434bis-09, March 26,
2008, <https://www.ietf.org/archive/id/draft-narten-iana-c
Copy link
Contributor

@cabo cabo Feb 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/ietf-tools/xml2rfc/pull/965/#issuecomment-1413237933

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is ugly.

@kesara kesara mentioned this pull request Feb 2, 2023
Open
1 task
@kesara
Copy link
Member Author

kesara commented Feb 2, 2023

Wow, this change seems to have a wide-ranging effect. Do we really want to stop breaking on hyphens everywhere? Note that Unicode has a non-breaking hyphen character ‑, U+2011, for where this is actually desired.

@cabo This change was just a proposal for review. I preferred this because this affects the whole text wrapping. But as you pointed out there are undesirable effects on URLs, but code can be changed to treat URLs differently.

See #961 (comment)
We better to move this conversation to that issue until we figure out which way to go.

@rjsparks
Copy link
Member

rjsparks commented Feb 2, 2023

convert this to draft?

@kesara kesara marked this pull request as draft February 2, 2023 20:07
@kesara
Copy link
Member Author

kesara commented Feb 2, 2023

Closing this as this is not the desired solution.

@kesara kesara closed this Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cabo cabo cabo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

one extraneous space in text output of figure name
3 participants
@kesara @cabo @rjsparks