Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(text): Render list items correctly #1137

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(text): Render list items correctly #1137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d1ba2ea
fix: Render ol items correctly
kesara Jul 9, 2024
efb4df6
fix: Insert a new line to li rather than skipping
kesara Jul 10, 2024
d9db9aa
test: Add test for ul with empty bullets
kesara Dec 8, 2024
cf194c7
chore: Run yestests pre-changes
kesara Dec 8, 2024
ef83be5
chore: Run yestests post-changes
kesara Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions tests/input/elements.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1362,6 +1362,26 @@ for opt, value in opts:
</artwork>
<t><xref target="GEDICHTE" format="title"/></t>
</li>
<li>
<t>ul with no bullets</t>
<ul empty="true">
<li>
<ul>
<li>Must not have an empty line with bullet above this line.</li>
</ul>
</li>
</ul>
</li>
<li>
<t>ul with bullets</t>
<ul>
<li>
<ul>
<li>Must have an empty line with bullet above this line.</li>
</ul>
</li>
</ul>
</li>
</ul>
</section>
</middle>
Expand Down
106 changes: 53 additions & 53 deletions tests/valid/elements.bom.text
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,9 @@ Table of Contents
CMS References . . . . . . . . . . . . . . . . . . . . . . . 25
ESS References . . . . . . . . . . . . . . . . . . . . . . . 26
MIME-SPEC References . . . . . . . . . . . . . . . . . . . . 26
Other References . . . . . . . . . . . . . . . . . . . . . . 26
Other References . . . . . . . . . . . . . . . . . . . . . . 27
Appendix A. Some Back Matter . . . . . . . . . . . . . . . . . . 27
A.1. Contributors . . . . . . . . . . . . . . . . . . . . . . 27
A.1. Contributors . . . . . . . . . . . . . . . . . . . . . . 28
A.2. Arbitrary^superscript in section _title_ . . . . . . . . 28
Authors' Addresses . . . . . . . . . . . . . . . . . . . . . . . 28

Expand Down Expand Up @@ -450,6 +450,7 @@ Author, et al. Expires 13 January 2019 [Page 8]
Internet-Draft Xml2rfc Vocabulary V3 Elements July 2018


4.
4.1 Sublist with '%p' parent counter element in the list
counter, item one

Expand Down Expand Up @@ -500,7 +501,6 @@ Internet-Draft Xml2rfc Vocabulary V3 Elements July 2018




Author, et al. Expires 13 January 2019 [Page 9]

Internet-Draft Xml2rfc Vocabulary V3 Elements July 2018
Expand Down Expand Up @@ -1351,13 +1351,23 @@ Internet-Draft Xml2rfc Vocabulary V3 Elements July 2018
* Indent="5". “The heaviest penalty for declining to rule is to
be ruled by someone inferior to yourself.” Πολιτεία

*
Ich weiß nicht, was soll es bedeuten,
Daß ich so traurig bin;
Ein Mährchen aus alten Zeiten,
Das kommt mir nicht aus dem Sinn.

Dreiunddreißig Gedichte

* ul with no bullets

o Must not have an empty line with bullet above this line.

* ul with bullets

-
o Must have an empty line with bullet above this line.

References

Normative References
Expand All @@ -1379,6 +1389,19 @@ Informative References

CMS References









Author, et al. Expires 13 January 2019 [Page 25]

Internet-Draft Xml2rfc Vocabulary V3 Elements July 2018


[I-D.levkowetz-xml2rfc-v3-implementation-notes]
Levkowetz, H., "Implementation notes for RFC7991,", Work
in Progress, Internet-Draft, draft-levkowetz-xml2rfc-v3-
Expand All @@ -1395,13 +1418,6 @@ CMS References
RFC 5652, DOI 10.17487/RFC5652, September 2009,
<https://www.rfc-editor.org/info/rfc5652>.



Author, et al. Expires 13 January 2019 [Page 25]

Internet-Draft Xml2rfc Vocabulary V3 Elements July 2018


ESS References

[RFC2634] Hoffman, P., Ed., "Enhanced Security Services for S/MIME",
Expand Down Expand Up @@ -1435,6 +1451,13 @@ MIME-SPEC References
Examples", RFC 2049, DOI 10.17487/RFC2049, November 1996,
<https://www.rfc-editor.org/info/rfc2049>.



Author, et al. Expires 13 January 2019 [Page 26]

Internet-Draft Xml2rfc Vocabulary V3 Elements July 2018


[RFC4289] Freed, N. and J. Klensin, "Multipurpose Internet Mail
Extensions (MIME) Part Four: Registration Procedures",
BCP 13, RFC 4289, DOI 10.17487/RFC4289, December 2005,
Expand All @@ -1447,17 +1470,6 @@ MIME-SPEC References

Other References







Author, et al. Expires 13 January 2019 [Page 26]

Internet-Draft Xml2rfc Vocabulary V3 Elements July 2018


[AUTHORS] Πυθαγόρας ὁ Σάμιος (Samos, P. O.), Doe, J., Bergström, A.,
and J. Doe, "Lots of authors", RFC 7539,
DOI 10.17487/RFC7539, May 2015,
Expand Down Expand Up @@ -1493,6 +1505,15 @@ Appendix A. Some Back Matter
// This is a long comment line which extends well beyond the
// 72-character page width.





Author, et al. Expires 13 January 2019 [Page 27]

Internet-Draft Xml2rfc Vocabulary V3 Elements July 2018


A.1. Contributors

We'd like to thank these contributors:
Expand All @@ -1505,15 +1526,6 @@ A.1. Contributors

Additional contact information:





Author, et al. Expires 13 January 2019 [Page 27]

Internet-Draft Xml2rfc Vocabulary V3 Elements July 2018


רוני אבן
וואווי
דוד המלך 14
Expand Down Expand Up @@ -1547,6 +1559,17 @@ Authors' Addresses

Additional contact information:







Author, et al. Expires 13 January 2019 [Page 28]

Internet-Draft Xml2rfc Vocabulary V3 Elements July 2018


רוני אבן
וואווי
דוד המלך 14
Expand All @@ -1563,13 +1586,6 @@ Authors' Addresses

Additional contact information:



Author, et al. Expires 13 January 2019 [Page 28]

Internet-Draft Xml2rfc Vocabulary V3 Elements July 2018


田中花子 様
日本
〒112-0001
Expand Down Expand Up @@ -1604,21 +1620,5 @@ Internet-Draft Xml2rfc Vocabulary V3 Elements July 2018




















Author, et al. Expires 13 January 2019 [Page 29]
Loading
Loading