Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid breaking citation labels #1114

Merged
merged 3 commits into from
Mar 18, 2024
Merged

fix: Avoid breaking citation labels #1114

merged 3 commits into from
Mar 18, 2024

Conversation

kesara
Copy link
Member

@kesara kesara commented Mar 15, 2024

Fixes #685

@kesara kesara marked this pull request as ready for review March 17, 2024 06:41
@kesara kesara requested a review from rjsparks March 17, 2024 06:41
rjsparks
rjsparks approved these changes Mar 17, 2024
View reviewed changes
Copy link
Member

@rjsparks rjsparks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this, but only based on the principle of the idea. The tests don't give us an automated way to see what the effect is on the pdf. Kesara and the RPC have been working on manually checking a largish set of documents where this style change would have some effect, but I have not dried to diff the pdfs myself.

@kesara kesara merged commit 312b01a into ietf-tools:main Mar 18, 2024
13 checks passed
@kesara kesara deleted the fix/avoid-xref-label-break branch March 18, 2024 00:09
@marco-tiloca-sics
Copy link

Hi! I just wanted to check if a new release of xml2rfc including this fix is planned to happen soon.

This issue in the current version of the tool is holding the publication as an RFC of https://datatracker.ietf.org/doc/draft-ietf-core-target-attr/

@kesara
Copy link
Member Author

kesara commented Apr 8, 2024

Hi! I just wanted to check if a new release of xml2rfc including this fix is planned to happen soon.

This issue in the current version of the tool is holding the publication as an RFC of https://datatracker.ietf.org/doc/draft-ietf-core-target-attr/

@marco-tiloca-sics Apologies for the wait. I've made a new release with the fix. See v3.21.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjsparks rjsparks rjsparks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prevent line break within citation in PDF output
3 participants
@kesara @marco-tiloca-sics @rjsparks