fix: Allow non-ASCII values in all attributes #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesara
force-pushed
the
fix/non-ascii-attributes
branch
from
563fe90 to
1e21000
Compare
|
Thanks for the quick fix! I'm not sure why you are taking out the latinscript tests for the ascii... attributes; I think these were useful. |
|
@cabo My initial thoughts were they are not required any more because all Unicode characters are allowed. |
kesara
force-pushed
the
fix/non-ascii-attributes
branch
from
1e21000 to
3874ba8
Compare
|
Looks good to me now. The warning message uses "they" to refer to "non-ASCII content", maybe "it"? |
rjsparks
approved these changes
Feb 20, 2024
PR ietf-tools#1017 allowed Unicord characters everywhere. This fixes a bug that xml2rfc was guarding against non-ASCII characters in attribute values. With `--warn-bare-unicode`, xml2rfc will warn if non-ASCII characters are present in attribute values. Fixes ietf-tools#1105
kesara
force-pushed
the
fix/non-ascii-attributes
branch
from
3874ba8 to
31bfab7
Compare
rjsparks
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #1017 allowed Unicord characters everywhere.
This fixes a bug that xml2rfc was guarding against non-ASCII characters in attribute values.
With
--warn-bare-unicode, xml2rfc will warn if non-ASCII characters are present in attribute values.Fixes #1105