Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: separate concerns / rename notify_events #8328

Merged
merged 5 commits into from
Dec 12, 2024

Conversation

jennifer-richards
Copy link
Member

Splits the signal receiver logic from the task queuing logic in a way that improves testability. Testing whether a notification email was sent is now just a simple mock to check whether ietf.community.models.notify_of_event() was called with the event.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (6b77807) to head (1f6c0f1).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8328   +/-   ##
=======================================
  Coverage   88.72%   88.73%           
=======================================
  Files         310      312    +2     
  Lines       40882    40892   +10     
=======================================
+ Hits        36273    36285   +12     
+ Misses       4609     4607    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit 70ab711 into ietf-tools:main Dec 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants