Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove unreliable statistics #8307

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

rjsparks
Copy link
Member

@rjsparks rjsparks commented Dec 5, 2024

Partially addresses #3712

Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question inline, but that's just curiosity.

@@ -809,8 +809,8 @@ def skip_unreadable_post(record):
SESSION_REQUEST_FROM_EMAIL = 'IETF Meeting Session Request Tool <[email protected]>'

SECRETARIAT_SUPPORT_EMAIL = "[email protected]"
SECRETARIAT_ACTION_EMAIL = "[email protected]"
SECRETARIAT_INFO_EMAIL = "[email protected]"
SECRETARIAT_ACTION_EMAIL = SECRETARIAT_SUPPORT_EMAIL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What were the replaced addresses doing? Old aliases in the mail system?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the secretariat used to use these aliases to drop tickets into separate queues for different types of requests. Now, everything is intended to go support@ instead, with queuing happening later, so that the community doesn't have to figure out which of many addresses to use. We have code that could be refactored to simplify having this many settings, but that should be a separate PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also - the other aliases just forward to support@ currently

@rjsparks rjsparks merged commit 3055d17 into ietf-tools:main Dec 9, 2024
6 of 7 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants