Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add wiki button to agenda list for hackathon sessions #8133

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

NGPixel
Copy link
Member

@NGPixel NGPixel commented Nov 3, 2024

  • Adds a wiki button (blue book icon) in lieu of the notepad button for hackathon sessions (notepad being irrelevant and never used for them AFAIK). See below for example.
  • Replaces the special arrow symbol on the "Switch to text-only version" button while the agenda is loading with a standard » symbol. Should fix the arrow sometimes changing to a weird icon because of incorrect font / charset / font not loaded.

image

@NGPixel NGPixel requested a review from rjsparks November 3, 2024 09:19
@rjsparks
Copy link
Member

rjsparks commented Nov 7, 2024

I'm not sure on this one.
I think we should split the arrow font out into its own PR.
I'd like to talk about generalizing this to other sessions that have different things than the default notes location.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.73%. Comparing base (6b77807) to head (3ad2f29).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8133   +/-   ##
=======================================
  Coverage   88.72%   88.73%           
=======================================
  Files         310      310           
  Lines       40882    40882           
=======================================
+ Hits        36273    36276    +3     
+ Misses       4609     4606    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants