Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alt diagrams #31

Closed
wants to merge 1 commit into from
Closed

Add alt diagrams #31

wants to merge 1 commit into from

Conversation

OR13
Copy link

@OR13 OR13 commented Aug 30, 2024

Screenshot 2024-08-30 at 3 52 10 PM

@thomas-fossati
Copy link
Collaborator

Good start!

Immediate comments:

  1. imprint must be messageImprint (from RFC3161)
  2. Adding "Clock" is like dissecting a frog, innit? :-) (we can add a legenda as in Move detailed diagrams up a level #30)
  3. The Signer box in the TTC diagram is a bit too crowded and hard to grasp
  4. the fact that private-key is repeated is confusing
  5. I am not yet sure if I like the stray unprotected box, but I could be convinced otherwise

@thomas-fossati
Copy link
Collaborator

Also, maybe rename them to alt-{ttc,cct}.ascii-art and tweak the include directive.

thomas-fossati added a commit that referenced this pull request Sep 10, 2024
@thomas-fossati
Copy link
Collaborator

Thanks @OR13 - I have pulled your nice diagrams into #30

This PR is closed as a consequence of the above.

thomas-fossati added a commit that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants