Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC9162 inclusion proofs do not include leaf #20

Open
ad-l opened this issue Jul 11, 2023 · 2 comments
Open

RFC9162 inclusion proofs do not include leaf #20

ad-l opened this issue Jul 11, 2023 · 2 comments

Comments

@ad-l
Copy link

ad-l commented Jul 11, 2023

The latest set of changes have removed the serialized leaf from the RFC9162-log inclusion proof. This is problematic for SCITT because the expectation was that verification of a COSE signed Merkle Proof would be self-contained (the CCF ledger ID is forced to make the serialization explicit because the leaf carries additional metadata).

Generally, I would argue that a proof type is only well defined if all inputs required for proof verification are carried in the COMETRE CBOR definition of the proof value. Otherwise, the question of the serialization of these additional inputs becomes ambiguous and you may end up with a mix of CBOR and other formats. Furthermore, it is difficult for implementations of validation libraries to define the API if they have to consider additional inputs for some verifiable data structures or some proof types.

@OR13 OR13 transferred this issue from ietf-scitt/draft-steele-cose-merkle-tree-proofs Sep 6, 2023
@OR13
Copy link
Collaborator

OR13 commented Sep 6, 2023

@ad-l I moved this issue here, but I think it belongs on https://github.com/cose-wg/draft-ietf-cose-merkle-tree-proofs

@OR13
Copy link
Collaborator

OR13 commented Sep 6, 2023

@ad-l Can you open a fresh issue, documenting what changes you want to see in the spec (on the wg repo)? or close this issue as being stale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants