Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugging CMW into EAT submods #118

Merged
merged 14 commits into from
Oct 20, 2024
Merged

Allow plugging CMW into EAT submods #118

merged 14 commits into from
Oct 20, 2024

Conversation

thomas-fossati
Copy link
Collaborator

No description provided.

@thomas-fossati thomas-fossati changed the title Cmw in submods Allow plugging CMW into EAT submods Sep 30, 2024

To address the composite Attester use case, this document defines a CMW "collection" as a container that holds several CMW items, each with a label that is unique within the scope of the collection.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why this text should be removed.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not removed, it's just been expanded in L269:

"To allow aggregation of multiple, potentially non-homogeneous evidence formats collected from different AEs, this document ..."

Comment on lines 296 to 298
When a CMW is used to carry the Evidence for composite or layered attestation for a single device, the security properties needed are that of attestation.
In particular, all the members in a CMW must be bound together so that an attacker can not replace one Evidence message showing compromise with that from a non-compromised device.
The authenticity and integrity protection MUST be attestation-oriented.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what these lines are compelling me to do. Why aren't lines 292 - 294 sufficient to convey that expectation that security of the CMW isn't part of this document? The normative wording seems to contradict the previous paragraph. It seems to acknowledge an additional security consideration that an active attacker could drop portions of the collection - which is an attack that is reasonably covered in lines 292-294.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This captures the third point from Laurence's email:

"The third thing is discussion of security when the use case is attestation Evidence, in which case the full attestation security model is necessary (which is more than integrity protection or a CWT)."

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wording seems awkward. Is it different from: "A CMW collection is subject to a variety of security threats such as insertion / removal of CMW contents, replay, misdirection, snooping, etc."

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since CMW doesn't define security mechanisms, it seems impossible for an implementer to satisfy the MUST requirement. I'm not sure what "attestation oriented" means. It reads like normative on some other spec besides this spec.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since CMW doesn't define security mechanisms, it seems impossible for an implementer to satisfy the MUST requirement.

I agree that the MUST here is unenforceable. I'll remove it and rephrase Laurence's point to keep the same "strength of signal" without bothering RFC2119.

I'm not sure what "attestation oriented" means. It reads like normative on some other spec besides this spec.

He means obeying https://www.rfc-editor.org/rfc/rfc9334.html#section-12.1

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see 5c5928a

@hannestschofenig hannestschofenig marked this pull request as ready for review October 19, 2024 19:02
Copy link
Collaborator

@nedmsmith nedmsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannestschofenig hannestschofenig merged commit 39e6c77 into main Oct 20, 2024
2 checks passed
@hannestschofenig hannestschofenig deleted the cmw-in-submods branch October 20, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants