Section restructuring #329
Conversation
Created a section for acs augmentation and put ACS requirements, and phase 2 - 4 sections inside. order of triple processing became part of ACS requirements and augmentation using CoMID triples became introduction to the new ACS augmentation section
nedmsmith
requested review from
henkbirkholz,
thomas-fossati and
yogeshbdeshpande
as code owners
| The `state-triples` field contains Evidence (from Attesters) and Endorsements | ||
| (e.g. from `endorsed-triple-record`). | ||
|
|
||
| CoMID Reference Values will be matched against the ACS, as per |
There was a problem hiding this comment.
CoMID reference value matching isn’t up to policy. We define it here?
| added to the ACS under the authority of a cryptographic key. | ||
|
|
||
| Each Claim is encoded as an ECT. The `environment-map` and a | ||
| key within `measurement-values-map` encode the name of the Claim. |
There was a problem hiding this comment.
refer issue #334
| Most triples use an `environment-map` field to select the ACS entries to match or modify. | ||
| This field may be contained in an explicit matching condition, such as `stateful-environment-record`. | ||
|
|
||
| The order of triples processing is important. |
There was a problem hiding this comment.
The order should not be important so long as additions are followed by triple processing that has a condition that could match it. We don’t want to impose other order dependencies unless you need to stratify triple processing more explicitly.
Given that we’re defining a processing order for base triples, it should also be allowable for profiles to specify when their triples get processed if indeed order is important. Will they always be after the base triples, or can they be specified to happen at any time?
There was a problem hiding this comment.
refer to issue #335
|
@nedmsmith Are you proposing ACS Addition Sections in this PR ahead of Defining the Triples ? if No, then sorry I mis-understood. If Yes, then we have a serious issue! |
|
Ignore my earlier comment, I think i got the hang of the PR now! |
|
This PR isn't trying to make content changes to sections. Merely moving sections around. There is still more work to do to get the content right. |
Co-authored-by: Dionna Amalie Glaze <[email protected]>
Co-authored-by: Dionna Amalie Glaze <[email protected]>
fix broken cross references
Created a section for acs augmentation and put ACS requirements, and phase 2 - 4 sections inside. order of triple processing became part of ACS requirements and augmentation using CoMID triples became introduction to the new ACS augmentation section
This PR addresses issues #320 and #324
Note that PR #323 overlaps this PR possibly requiring manual merge.