Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new twitter name resolver #46

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: new twitter name resolver #46

wants to merge 3 commits into from

Conversation

adiusz
Copy link

@adiusz adiusz commented Jan 2, 2024

No description provided.

@nemmtor
Copy link
Contributor

nemmtor commented Jan 6, 2024 •
edited
Loading

@adiusz @lennardevertz
Can we postpone this PR until we merge #45 ?
It includes major refactoring and there will be conflicts. Probably easier to solve them here

EDIT: actually can you just rebase on top of #45 and apply these changes there?

nemmtor
nemmtor reviewed Jan 6, 2024
View reviewed changes
src/baseIdrissCrypto.ts Outdated Show resolved Hide resolved
src/browser.ts Outdated Show resolved Hide resolved
src/baseIdrissCrypto.ts Outdated Show resolved Hide resolved
src/twitterNameResolver.ts Outdated Show resolved Hide resolved
src/twitterNameResolver.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nemmtor nemmtor nemmtor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adiusz @nemmtor