TDDwI: Minor changes to chapter10 #3433
Open
+16
−20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this is the right place to suggest changes to https://idris2.readthedocs.io/en/latest/typedd/typedd.html.
While following the TypeDD book with idris2, I noticed that the code can be made total whilst resembling the original code more.
I checked the code with
idris2 --check tests/typedd-book/chapter10/IsSuffix.idr
but didn't run any tests because I didn't really understand how it works.Unrelated, but I feel like it would be nicer if the
Snoc
constructor was changed from:to something better resembling idris1:
I assume there is a valid motivation for this change that I didn't catch, as I've never used Idris outside of the purposes of this book.