Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for non-glibc versions of linux (musl, android) #3336

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spocino
Copy link

@spocino spocino commented Jun 29, 2024

check if a linux implementation uses glibc to decide whether to load "glibc.so.6" or "glibc.so"

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Z-snails
Copy link
Collaborator

Would it be easier/faster to try loading libc.so.6 first, then if that fails try libc.so (using with-exception-handler) - that way we don't need to spawn a child process.

@mattpolzin
Copy link
Collaborator

I think that suggestion makes sense to me too; I think we could go even further and avoid the runtime check or fallback entirely too since our goal in loading the dynamic library is not actually to build once and then run in multiple different environments so we ought to be able to determine which library to use at compile time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants