Add global package directory to search paths (and update Idris2 submodule) #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattpolzin
changed the title
|
Since this is a necessary fix for the idris2-lsp to keep working with pack, I'm going to merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request will be necessitated by idris-lang/Idris2#3214 but it will also fail to build until that PR has merged.
In short, the global package search path has been moved out of a function called by both the compiler and the LSP and into the compiler's
updateEnvfunction which the LSP largely reproduces in itsMainmodule. The change in this PR mirrors the one made toupdateEnvin the compiler. You can see the analogous change in the upstream PR here: https://github.com/idris-lang/Idris2/pull/3214/files#diff-2459d1bfe7d1e6e584656adf0a5d01e88b5de037ce1785d9a1ff432a04b43f80R79-R84.