Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: optimize drawing element and resizing in-group #258

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Conversation

chenshenhai
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Attention: 150 lines in your changes are missing coverage. Please review.

Comparison is base (d6f859f) 6.40% compared to head (09a9c8e) 6.29%.
Report is 70 commits behind head on main.

Files Patch % Lines
packages/util/src/lib/resize-element.ts 1.49% 45 Missing and 21 partials ⚠️
packages/renderer/src/draw/circle.ts 0.00% 15 Missing and 6 partials ⚠️
packages/util/src/lib/handle-element.ts 0.00% 13 Missing and 6 partials ⚠️
packages/core/src/middleware/selector/index.ts 0.00% 6 Missing and 2 partials ⚠️
packages/renderer/src/draw/box.ts 0.00% 7 Missing and 1 partial ⚠️
packages/util/src/lib/data.ts 0.00% 7 Missing and 1 partial ⚠️
packages/renderer/src/draw/group.ts 0.00% 4 Missing ⚠️
packages/renderer/src/draw/html.ts 0.00% 3 Missing ⚠️
packages/renderer/src/draw/image.ts 0.00% 3 Missing ⚠️
packages/renderer/src/draw/svg.ts 0.00% 3 Missing ⚠️
... and 6 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #258      +/-   ##
========================================
- Coverage   6.40%   6.29%   -0.12%     
========================================
  Files         75      76       +1     
  Lines       4230    4320      +90     
  Branches     831     855      +24     
========================================
+ Hits         271     272       +1     
- Misses      3157    3222      +65     
- Partials     802     826      +24     
Flag Coverage Δ
unittests 6.29% <1.31%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chenshenhai chenshenhai merged commit 6ae72ba into main Dec 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants