Merge pull request #264 from idrawjs/dev-v0.4

fix: fix addElement logic
idrawjs · Jan 7, 2024 · 024f1a5 · 024f1a5
2 parents 2374058 + 916c504
commit 024f1a5
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/packages/idraw/src/idraw.ts b/packages/idraw/src/idraw.ts
@@ -151,7 +151,7 @@ export class iDraw {
     this.#core.off(name, callback);
   }
 
-  trigger<T extends keyof IDrawEvent>(name: T, e: IDrawEvent[T]) {
+  trigger<T extends keyof IDrawEvent>(name: T, e?: IDrawEvent[T]) {
     this.#core.trigger(name, e);
   }
 
@@ -212,10 +212,11 @@ export class iDraw {
   ): Data {
     const core = this.#core;
     const data: Data = core.getData() || { elements: [] };
-    if (!opts) {
+    if (!opts || !opts?.position?.length) {
       data.elements.push(element);
     } else if (opts?.position) {
-      insertElementToListByPosition(element, opts?.position, data.elements);
+      const position = [...opts?.position];
+      insertElementToListByPosition(element, position, data.elements);
     }
     core.setData(data);
     core.refresh();

diff --git a/packages/util/src/lib/event.ts b/packages/util/src/lib/event.ts
@@ -32,7 +32,7 @@ export class EventEmitter<T extends Record<string, any>> implements UtilEventEmi
     }
   }
 
-  trigger<K extends keyof T>(eventKey: K, e: T[K]) {
+  trigger<K extends keyof T>(eventKey: K, e?: T[K]) {
     const callbacks = this.#listeners.get(eventKey);
     if (Array.isArray(callbacks)) {
       callbacks.forEach((cb) => {