Adapt plugincache MergeStrategy to sbt-assembly:2.0.0 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update MergeStrategy code to use temp files to extract the InputStreams Update the sbt assembly plugin to use 2.0.0-RC1 Update the log4j version to 2.17.2 Update version to 2.1.0
|
Thank you for this PR. The project seems unmaintained, so I took the liberty to fork it, include your PR, upgrade everything and release it to maven central. I added you to the https://github.com/mpollmeier/sbt-assembly-log4j2#credits and hope that's ok? |
This was referenced Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update MergeStrategy code to use temp files to extract the InputStreams
Update the sbt assembly plugin to use 2.0.0-RC1
Update the log4j version to 2.17.2
Update version to 2.1.0
Hey maintainers,
We need to update this for the upcoming sbt-assembly 2.0.0 (right now it's in RC1 mode)
Background
sbt-assembly has recently been updated to use a streaming/in-memory model instead of IO/disk-extraction model. Due to this, the method signature of the
MergeStrategyhas changed.I also went ahead and updated the log4j dependency to
2.17.2to fix that infamous vulnerability.