Skip to content

Commit

Permalink
[CRAN] Update cran-comments.md for resubmission
Browse files Browse the repository at this point in the history
  • Loading branch information
Hongyuan Jia committed Jul 7, 2020
1 parent 3c8daad commit 02c62c0
Showing 1 changed file with 11 additions and 13 deletions.
24 changes: 11 additions & 13 deletions cran-comments.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,22 +19,20 @@
Comments from CRAN maintainer:

```
Please add hyperlinks to the websites of the diffeent projects in the
form <https://.....>.
Thanks, please replace \dontrun{} by \donttest{} in your Rd-files, if
the functions do not need an API key.
Please single quote software names and other non English usage in Title
and Description fields, e.g. write 'EnergyPlus'.
The Title field should be in title case. Current version is:
Create future EnergyPlus Weather files using CMIP6 data
In title case that is:
'Create Future 'EnergyPlus' Weather Files using 'CMIP6' Data
Please ensure that your functions do not modify (save or delete) the
user's home filespace in your examples/vignettes/tests. That is not
allow by CRAN policies. Please only write/save files if the user has
specified a directory. In your examples/vignettes/tests you can write to
tempdir().
Please fix and resubmit.
```

I corrected the `Title` field in DESCRIPTION into title case,
single-quoted all abbreviations, and added all links for external
projects.
Revisions:

* I change the example of `get_data_node()` to `\donttest{}`.
* Now all functions will not write to user home filespace by default.
* I change Tests so that it only writes to `tempdir()`.

0 comments on commit 02c62c0

Please sign in to comment.