-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added PR template #217
base: trunk
Are you sure you want to change the base?
added PR template #217
Conversation
WalkthroughThe recent update introduces a new Pull Request (PR) template in the project's GitHub repository. This template outlines checklist items for contributors, PR types, ticket details, behavior changes, feature flags, and provides additional context along with the AppScan CodeSweep failure protocol. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Out of diff range and nitpick comments (2)
.github/PULL_REQUEST_TEMPLATE.md (2)
6-6
: Consider rephrasing to clarify the use of "let helpers and before blocks" in tests.Perhaps specify that these are related to RSpec testing practices for clarity.
17-52
: Consider using secondary headings (##) for sub-sections under the main heading.This helps in maintaining a clear structure and improves the readability of the document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markgoho @kristinmerbach Please review my comment.
|
||
Include any additional context that may be relevant to the peer review process. | ||
|
||
# AppScan CodeSweep Failure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kristinmerbach @polographer AppScan CodeSweep Failure
is not applicable for Fdsh GW.
Summary by CodeRabbit