Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add updated EventSource - wait for rails to be ready #154

Merged
merged 4 commits into from
Sep 24, 2024
Merged

add updated EventSource - wait for rails to be ready #154

merged 4 commits into from
Sep 24, 2024

Conversation

vkghub
Copy link
Contributor

@vkghub vkghub commented Sep 20, 2024 •
edited
Loading

@vkghub vkghub self-assigned this Sep 20, 2024
@vkghub vkghub marked this pull request as ready for review September 23, 2024 20:05
@vkghub vkghub requested a review from saikumar9 September 23, 2024 20:05
@vkghub vkghub requested a review from ymhari September 24, 2024 13:16
@saikumar9 saikumar9 enabled auto-merge (squash) September 24, 2024 14:51
saikumar9
saikumar9 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@saikumar9 saikumar9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

ymhari
ymhari approved these changes Sep 24, 2024
View reviewed changes
Copy link

@ymhari ymhari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@saikumar9 saikumar9 merged commit afb3e6a into trunk Sep 24, 2024
7 checks passed
@saikumar9 saikumar9 deleted the pivotal_188310215 branch September 24, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymhari ymhari ymhari approved these changes

@saikumar9 saikumar9 saikumar9 approved these changes

Assignees

@vkghub vkghub

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vkghub @saikumar9 @ymhari