Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert updating amount calculations for npt h41/1095A (#147)" #150

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

erubinst
Copy link
Contributor

@erubinst erubinst commented Aug 27, 2024

This reverts commit a2c7e39 as testing cannot be completed before deployment

Reverting work for ticket https://www.pivotaltracker.com/n/projects/2640059/stories/187756844

This work is saved and can be recovered when blocking issue is resolved and we can resume testing

The security issue is
Name: rexml
Version: 3.3.5
CVE: CVE-2024-43398
GHSA: GHSA-vmwr-mc7x-5vc3
Criticality: Medium
Title: REXML denial of service vulnerability
Solution: update to '>= 3.3.6'

which is unrelated to this revert

Copy link
Contributor

@jayreddy519 jayreddy519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert previous commit. lgtm.

please check the failures @erubinst

@erubinst erubinst merged commit b033b20 into trunk Oct 8, 2024
7 checks passed
@erubinst erubinst deleted the revert-147-npt_psa_fix_187756844 branch October 8, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants