Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating amount calculations for npt h41/1095A #147

Merged
merged 22 commits into from
Jun 20, 2024
Merged

Conversation

erubinst
Copy link
Contributor

@erubinst erubinst commented Jun 11, 2024

NPT Policies have incorrect values in their 1095A/H41 for the first and second grace period months.
The first grace period month should have PremAmt/SLCSP/APTC of 0/0/APTC if aptc applied and the second grace period month should have blank/blank/blank.

https://www.pivotaltracker.com/n/projects/2640059/stories/187756844

@erubinst erubinst marked this pull request as ready for review June 11, 2024 18:57
@erubinst erubinst requested a review from nks2109 June 11, 2024 18:57
Copy link
Contributor

@nks2109 nks2109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good but can you add test cases? Thank you!

@erubinst erubinst requested a review from nks2109 June 13, 2024 19:28
@erubinst erubinst requested a review from jayreddy519 June 18, 2024 13:56
@erubinst erubinst merged commit a2c7e39 into trunk Jun 20, 2024
7 checks passed
@erubinst erubinst deleted the npt_psa_fix_187756844 branch June 20, 2024 17:51
@erubinst erubinst restored the npt_psa_fix_187756844 branch August 27, 2024 18:21
erubinst added a commit that referenced this pull request Aug 27, 2024
TreyE added a commit that referenced this pull request Sep 19, 2024
erubinst added a commit that referenced this pull request Oct 8, 2024
Revert "updating amount calculations for npt h41/1095A (#147)"

This reverts commit a2c7e39.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants