Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reuse IVs and add future placeholder for key rotation. #422

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from

Conversation

TreyE
Copy link
Contributor

@TreyE TreyE commented Oct 3, 2023

Ticket: https://www.pivotaltracker.com/story/show/186126008

This submission makes some updates to the way encryption of sensitive values is performed in ACA Entities:

  1. Generate a unique IV for each encryption round to prevent nonce-reuse attacks
  2. Adds a payload header with versioning support so that in the future we can perform key and algorithm rotation
  3. Maintains backward compatibility and the ability to decrypt values already encrypted using the 'legacy' algorithm
  4. Maintains the existing, established API so upgrades are transparent

While evaluating this ticket, I want to keep a list of testing necessities/gotchas that this update introduces:

  1. Gotcha - all systems which use ACA Entities in an environment will need to update to use this version at the same time. While in actuality it would suffice to only need to promote ACA Entities for applications which consume encrypted payloads, the interconnection of our various applications is most likely too complex to make the determination as to which applications, if any, perform only this role.
  2. Gotcha - it doesn't seem we have an inventory of all applications which use ACA Entities and what version they currently use, so that we could spot compatibility issues when we promote.

@TreyE TreyE force-pushed the pt-186126008 branch 2 times, most recently from 06bc12f to d5e2b7b Compare October 3, 2023 21:54
@TreyE TreyE added the security Pull requests that address a security vulnerability label Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Pull requests that address a security vulnerability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants