Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker compose #21

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Docker compose #21

wants to merge 4 commits into from

Conversation

bar9
Copy link
Collaborator

@bar9 bar9 commented Dec 29, 2020

Docker-Compose setup with documentation

@bar9 bar9 requested review from TheFern2 and Bukii December 29, 2020 07:42
@TheFern2
Copy link
Contributor

TheFern2 commented Dec 29, 2020

@bar9 I'll test this docker config sometime in the weekend. I think both Dockerfile, and docker-compose.yml should be Dockerfile.example kind of like the .env.example so if a user wants to make changes they won't need to worry about git tracking those changes. And then Dockerfile and docker-compose.yml should be on gitignore.

Another note, on the Dockerfile I see expose 8080, but not 5432, is that OK? Or should that port be exposed too?
I tried to run and kept getting stories db doesn't exists, isn't that something that can be configured with docker?

@bar9
Copy link
Collaborator Author

bar9 commented Jan 8, 2021

@bar9 I'll test this docker config sometime in the weekend. I think both Dockerfile, and docker-compose.yml should be Dockerfile.example kind of like the .env.example so if a user wants to make changes they won't need to worry about git tracking those changes. And then Dockerfile and docker-compose.yml should be on gitignore.

Yes, that makes sense

Another note, on the Dockerfile I see expose 8080, but not 5432, is that OK? Or should that port be exposed too?

No, we use the official postgres image in the compose file, they have already taken care of this

I tried to run and kept getting stories db doesn't exists, isn't that something that can be configured with docker?

Yes, we could do it with a startup script in the API container. Would probably requires some additional "wait-for"-loop so it only runs when the DB is ready

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants