Update Forward Sampling Workshop Slides #1895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanjm
force-pushed
the
workshop-presentations
branch
from
ce9c540
to
25a4c7e
Compare
wangcj05
reviewed
Jul 21, 2022
| @@ -0,0 +1,32 @@ | |||
| #!/usr/bin/env python | |||
There was a problem hiding this comment.
Please add raven copyright info
Comment on lines
10
to
11
| synth_fp = os.path.abspath(sys.argv[1]) | ||
| real_fp = os.path.abspath(os.path.join(os.path.dirname(synth_fp), "dataSet_0.csv")) |
There was a problem hiding this comment.
If possible, I suggest to use camelBack for the variables.
| ax.set_ylabel('Value') | ||
| ax.legend() | ||
|
|
||
| output_fp = os.path.join(os.path.dirname(real_fp), "results.png") |
There was a problem hiding this comment.
same comments here as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
#1806
What are the significant changes in functionality due to this change request?
Updates the Foward Sampler workshop powerpoints to use wide-format.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>to True.raven/tests/framework/user_guideandraven/docs/workshop) have been changed, the associated documentation must be reviewed and assured the text matches the example.