Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing feedback from PyOpenSci peer reviews. #440

Merged
merged 18 commits into from
Jul 17, 2024
Merged

Implementing feedback from PyOpenSci peer reviews. #440

merged 18 commits into from
Jul 17, 2024

Conversation

MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Jul 9, 2024 •
edited
Loading

Description

This is based on this review: pyOpenSci/software-submission#205

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)

@MicahGale MicahGale changed the title Made pypi very obvious. Implementing feedback from PyOpenSci peer reviews. Jul 10, 2024
@MicahGale MicahGale mentioned this pull request Jul 10, 2024
Open
32 tasks
MicahGale
MicahGale commented Jul 10, 2024
View reviewed changes
doc/source/starting.rst Outdated Show resolved Hide resolved
@MicahGale MicahGale self-assigned this Jul 10, 2024
@MicahGale MicahGale added documentation Improvements or additions to documentation code improvement A feature request that will improve the software and its maintainability, but be invisible to users. labels Jul 10, 2024
@MicahGale MicahGale marked this pull request as ready for review July 17, 2024 20:55
@MicahGale MicahGale requested a review from tjlaboss July 17, 2024 20:55
@MicahGale
Copy link
Collaborator Author

Removing scope of #331 for now because this needs to be merged for PyOpenSci reviews to continue, and #331 isn't critical path.

@MicahGale MicahGale mentioned this pull request Jul 17, 2024
Merged
tjlaboss
tjlaboss reviewed Jul 17, 2024
View reviewed changes
doc/source/starting.rst Outdated Show resolved Hide resolved
doc/source/starting.rst Outdated Show resolved Hide resolved
doc/source/starting.rst Outdated Show resolved Hide resolved
doc/source/starting.rst Outdated Show resolved Hide resolved
@tjlaboss
Copy link
Collaborator

I have added tests that prove my fix is effective or that my feature works (if applicable)

Let's delete the checkbox or check it so that it doesn't show 2/3 tasks

@MicahGale MicahGale requested a review from tjlaboss July 17, 2024 22:06
@MicahGale MicahGale enabled auto-merge July 17, 2024 22:07
@MicahGale MicahGale merged commit cd6d9c8 into develop Jul 17, 2024
14 checks passed
@MicahGale MicahGale deleted the py_open_sci branch July 17, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjlaboss tjlaboss tjlaboss approved these changes

Assignees

@MicahGale MicahGale

Labels
code improvement A feature request that will improve the software and its maintainability, but be invisible to users. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MicahGale @tjlaboss