Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency typescript-eslint to v8.18.1 #840

Merged
merged 1 commit into from
Dec 17, 2024

fix(deps): update dependency typescript-eslint to v8.18.1

6cb789a
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

fix(deps): update dependency typescript-eslint to v8.18.1 #840

fix(deps): update dependency typescript-eslint to v8.18.1
6cb789a
Select commit
Loading
Failed to load commit list.
GitHub Actions / golangci completed Dec 17, 2024 in 0s

reviewdog [golangci] report

reported by reviewdog 🐶

Findings (6)

backend/scoreserver/domain/team.go|12 col 2| the methods of "Team" use pointer receiver and non-pointer receiver. (recvcheck)
backend/pkg/pgtest/pgtest.go|88| pkg/pgtest/pgtest.go:88: Line contains TODO/BUG/FIXME: "TODO: startContainer を使って DB を起動し,tb.Cle..." (godox)
backend/cmd/scoreserver/main.go|30| Function 'start' is too long (62 > 60) (funlen)
backend/cmd/scoreserver/otel.go|120 col 13| string otlp has 4 occurrences, make it a constant (goconst)
backend/cmd/scoreserver/main.go|18 col 2| var flagContestantHTTPAddr is unused (unused)
backend/cmd/scoreserver/main.go|20 col 2| var flagTelemetryAddr is unused (unused)

Filtered Findings (0)

Annotations

Check failure on line 12 in backend/scoreserver/domain/team.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] backend/scoreserver/domain/team.go#L12

the methods of "Team" use pointer receiver and non-pointer receiver. (recvcheck)
Raw output
scoreserver/domain/team.go:12:2: the methods of "Team" use pointer receiver and non-pointer receiver. (recvcheck)
	Team     struct {
	^

Check failure on line 88 in backend/pkg/pgtest/pgtest.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] backend/pkg/pgtest/pgtest.go#L88

pkg/pgtest/pgtest.go:88: Line contains TODO/BUG/FIXME: "TODO: startContainer を使って DB を起動し,tb.Cle..." (godox)
Raw output
pkg/pgtest/pgtest.go:88: pkg/pgtest/pgtest.go:88: Line contains TODO/BUG/FIXME: "TODO: startContainer を使って DB を起動し,tb.Cle..." (godox)
	// TODO: startContainer を使って DB を起動し,tb.Cleanup で停止する

Check failure on line 30 in backend/cmd/scoreserver/main.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] backend/cmd/scoreserver/main.go#L30

Function 'start' is too long (62 > 60) (funlen)
Raw output
cmd/scoreserver/main.go:30: Function 'start' is too long (62 > 60) (funlen)
func start() int {

Check failure on line 120 in backend/cmd/scoreserver/otel.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] backend/cmd/scoreserver/otel.go#L120

string `otlp` has 4 occurrences, make it a constant (goconst)
Raw output
cmd/scoreserver/otel.go:120:13: string `otlp` has 4 occurrences, make it a constant (goconst)
	expType := "otlp"
	           ^

Check failure on line 18 in backend/cmd/scoreserver/main.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] backend/cmd/scoreserver/main.go#L18

var `flagContestantHTTPAddr` is unused (unused)
Raw output
cmd/scoreserver/main.go:18:2: var `flagContestantHTTPAddr` is unused (unused)
	flagContestantHTTPAddr = flag.String("contestant-http-addr", "0.0.0.0:8080", "Contestant API HTTP Address")
	^

Check failure on line 20 in backend/cmd/scoreserver/main.go

See this annotation in the file changed.

@github-actions github-actions / golangci

[golangci] backend/cmd/scoreserver/main.go#L20

var `flagTelemetryAddr` is unused (unused)
Raw output
cmd/scoreserver/main.go:20:2: var `flagTelemetryAddr` is unused (unused)
	flagTelemetryAddr      = flag.String("telemetry-addr", "0.0.0.0:9090", "Telemetry HTTP Address")
	^