Convert explicitely omitted ByRef arguments into temporary variables #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 22, 2024 16:36
TymurGubayev
changed the title
TymurGubayev
changed the title
Hopefully this stops someone tweaking the logic and forgetting to remove the parameter - there's already enough mutation of state going on with the forceNamedParameters aspect
…tedArguments/1 # Conflicts: # Tests/CSharp/MemberTests/MemberTests.cs
GrahamTheCoder
force-pushed
the
fix/ExplicitelyOmittedArguments/1
branch
from
381f396 to
d85f6b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#1107: OmittedArgumentSyntax isn't converted into temporary variable for ByRef parameters causing error CS7036
Solution
processedParameters.Add(parameterSymbol.Name);in these cases (by removing the just added name), to keep the number ofifs (and avoid nesting another one within). There are alternatives, but IMHO the tiny performance impact is ok.