Merge pull request #1127 from TymurGubayev/minor/DontUseNull/1

pass empty ParameterList instead of null
icsharpcode · Jul 30, 2024 · 1dd49d9 · 1dd49d9
2 parents 871f088 + 98cda07
commit 1dd49d9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/CodeConverter/CSharp/CommonConversions.cs b/CodeConverter/CSharp/CommonConversions.cs
@@ -145,7 +145,7 @@ public bool ShouldPreferExplicitType(VBSyntax.ExpressionSyntax exp,
                     equalsValueClauseSyntax = null;
                 } else {
                     var returnBlock = SyntaxFactory.Block(SyntaxFactory.ReturnStatement(adjustedInitializerExpr));
-                    _typeContext.PerScopeState.Hoist(new HoistedFunction(GetInitialValueFunctionName(vbName), csTypeSyntax, returnBlock, null));
+                    _typeContext.PerScopeState.Hoist(new HoistedFunction(GetInitialValueFunctionName(vbName), csTypeSyntax, returnBlock, SyntaxFactory.ParameterList()));
                     equalsValueClauseSyntax = null;
                 }
             } else {

diff --git a/CodeConverter/CSharp/ValidSyntaxFactory.cs b/CodeConverter/CSharp/ValidSyntaxFactory.cs
@@ -83,7 +83,6 @@ public static MethodDeclarationSyntax CreateMethod(string newMethodName, TypeSyn
     {
         var modifiers = SyntaxFactory.TokenList(SyntaxFactory.Token(SyntaxKind.StaticKeyword));
         var typeConstraints = SyntaxFactory.List<TypeParameterConstraintClauseSyntax>();
-        parameterList ??= SyntaxFactory.ParameterList();
 
         var methodAttrs = SyntaxFactory.List<AttributeListSyntax>();