Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More ruff & pre-commit rules #546

Merged
merged 25 commits into from
Aug 27, 2024
Merged

More ruff & pre-commit rules #546

merged 25 commits into from
Aug 27, 2024

Commits on Aug 8, 2024

  1. Add YAML checker 

    Adjust format of pre-commit config to more conventional YAML style
    @mfisher87
    mfisher87 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    a14ab37 View commit details
    Browse the repository at this point in the history

  2. Fix E711, E712, E714 lint errors with Ruff autofixer

    @mfisher87
    mfisher87 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    65e7ee4 View commit details
    Browse the repository at this point in the history

  3. Fix F401 and F841 lint errors

    @mfisher87
    mfisher87 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    8b3f79f View commit details
    Browse the repository at this point in the history

  4. Switch to ruff for linting and formatting

    @mfisher87
    mfisher87 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    2ca3021 View commit details
    Browse the repository at this point in the history

  5. Apply formatting

    @mfisher87
    mfisher87 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    5688faa View commit details
    Browse the repository at this point in the history

  6. Migrate GitHub Action to Ruff

    @mfisher87
    mfisher87 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    749cc55 View commit details
    Browse the repository at this point in the history

  7. Remove vestigial flake8 config 

    IMPORTANT: Ruff isn't added to requirements.txt because it's run through
pre-commit
    @mfisher87
    mfisher87 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    84f2b1f View commit details
    Browse the repository at this point in the history

  8. Enable a suite of additional Ruff rules

    @mfisher87
    mfisher87 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    bf61460 View commit details
    Browse the repository at this point in the history

  9. Fixes for new ruff rules 

    Mostly organizing imports with isort ("I") ruleset
    @mfisher87
    mfisher87 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    3d4959b View commit details
    Browse the repository at this point in the history

  10. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    2bd77fd View commit details
    Browse the repository at this point in the history

  11. Make sphinx announce script executable

    @mfisher87
    mfisher87 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    b479d90 View commit details
    Browse the repository at this point in the history

  12. Add more pre-commit checks

    @mfisher87
    mfisher87 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    3e9c1d2 View commit details
    Browse the repository at this point in the history

  13. Rename test file to follow convention

    @mfisher87
    mfisher87 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    8596ffc View commit details
    Browse the repository at this point in the history

  14. Apply formatter

    @mfisher87
    mfisher87 committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    ae0644d View commit details
    Browse the repository at this point in the history

  15. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 8, 2024
    Configuration menu
    Copy the full SHA
    b86a68a View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Merge branch 'development' into more-ruff-rules

    @weiji14
    weiji14 committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    a93662d View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 13, 2024
    Configuration menu
    Copy the full SHA
    fa768ed View commit details
    Browse the repository at this point in the history

  3. More explicitly declare ruff rules 

    Co-authored-by: Wei Ji <[email protected]>
    @mfisher87 @weiji14
    mfisher87 and weiji14 authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    5011535 View commit details
    Browse the repository at this point in the history

  4. Sort ruff linting rules alphabetically 

    Co-authored-by: Wei Ji <[email protected]>
    @mfisher87 @weiji14
    mfisher87 and weiji14 authored Aug 13, 2024
    Configuration menu
    Copy the full SHA
    facfd46 View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2024

  1. Adjust tests to account for renaming legacy test module 

    The module was renamed by a Ruff rule, but there are tests that depend
on the name of the module. Those tests are updated to the new module
name.

The legacy module was named without the `test_` prefix so that it
wouldn't be collected by the test runner. Because it does contain tests,
the prefix is added back, and now we tell the test runner to skip the
module and why.
    @mfisher87
    mfisher87 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    3956ca7 View commit details
    Browse the repository at this point in the history

  2. Clarify comment about high value rulesets

    @mfisher87
    mfisher87 committed Aug 14, 2024
    Configuration menu
    Copy the full SHA
    a4cf9df View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2024

  1. Merge branch 'development' into more-ruff-rules

    @mfisher87
    mfisher87 authored Aug 27, 2024
    Configuration menu
    Copy the full SHA
    3d631bb View commit details
    Browse the repository at this point in the history

  2. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    0b7447f View commit details
    Browse the repository at this point in the history

  3. Switch to sorting alphabetically within import sections 

    #546
    @mfisher87
    mfisher87 committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    088139b View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci
    pre-commit-ci[bot] committed Aug 27, 2024
    Configuration menu
    Copy the full SHA
    3c22771 View commit details
    Browse the repository at this point in the history