Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for commas in CLencryptedVesselIds, CLcomment, and CEencryptedVesselIds during upload #212

Open
davidcurrie2001 opened this issue Oct 25, 2024 · 4 comments
Labels

Comments

@davidcurrie2001
Copy link
Collaborator

During data upload can we check for commas in the CLencryptedVesselIds, CLcomment, and CEencryptedVesselIds fields and return a validation error if any are found?

@davidcurrie2001
Copy link
Collaborator Author

As a test I tried uploading CL data with CLencryptedVesselIds separated by commas. If I didn't quote the value then the validation failed, but if I quoted the field (i.e. "abc,def,ghi") then the upload succeeded. However when I downloaded the data that column only contained "abc

@HenrikK-N
Copy link
Collaborator

It is a priority to have a check for use of commas in the text fields especially CLencryptedVesselIds and CEencryptedVesselIds.

@HenrikK-N
Copy link
Collaborator

Check that it is mentioned in the description of the free text fields not to use commas.

@HenrikK-N
Copy link
Collaborator

A developer have checked that commas cannot be used as a separator in the CLencryptedVesselIds and CEencryptedVesselIds if the file is separated with commas, even though the CLencryptedVesselIds and CEencryptedVesselIds are in quotes. But if the file is separated by semicolons that the commas can be uploaded into the CLencryptedVesselIds and CEencryptedVesselIds, therefore we will remove the possibility to use semicolon as a file delimiter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants